[CELEBORN-1725][FOLLOWUP] Optimize isAllMapTasksEnd performance
#2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RexXiong
reviewed
Nov 28, 2024
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
Outdated
Show resolved
Hide resolved
onebox-li
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Thanks! I think this code fragment could be polished too . https://github.com/apache/celeborn/blob/main/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala#L455-L466
|
You can add a new PR to fix all similar code snippets. There are still some more |
turboFei
force-pushed
the
celeborn_1725_follow
branch
from
8c79f5b to
b065492
Compare
turboFei
force-pushed
the
celeborn_1725_follow
branch
from
2c50c20 to
e03ae05
Compare
Ok, thx |
turboFei
force-pushed
the
celeborn_1725_follow
branch
from
b065492 to
d9012d1
Compare
Thanks for the suggestion, will address it in CELEBORN-1753 for |
pan3793
reviewed
Nov 28, 2024
turboFei
force-pushed
the
celeborn_1725_follow
branch
from
e5b3c59 to
c1acead
Compare
pan3793
reviewed
Nov 28, 2024
client/src/main/scala/org/apache/celeborn/client/ClientUtils.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Nov 28, 2024
onebox-li
approved these changes
Nov 28, 2024
RexXiong
approved these changes
Nov 29, 2024
RexXiong
pushed a commit
that referenced
this pull request
Nov 29, 2024
### What changes were proposed in this pull request? Followup for #2905, using the same logic to optimize `isAllMapTasksEnd` method. ### Why are the changes needed? Address comments: #2905 (review) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Same logic with #2905 Closes #2959 from turboFei/celeborn_1725_follow. Authored-by: Wang, Fei <[email protected]> Signed-off-by: Shuang <[email protected]> (cherry picked from commit c84733f) Signed-off-by: Shuang <[email protected]>
RexXiong
pushed a commit
that referenced
this pull request
Nov 29, 2024
Followup for #2905, using the same logic to optimize `isAllMapTasksEnd` method. Address comments: #2905 (review) No. Same logic with #2905 Closes #2959 from turboFei/celeborn_1725_follow. Authored-by: Wang, Fei <[email protected]> Signed-off-by: Shuang <[email protected]> (cherry picked from commit c84733f) Signed-off-by: Shuang <[email protected]>
|
Thanks, merge to main(V0.6.0) and branch-0.5(v0.5.3) and branch-0.4(v0.4.3) |
RexXiong
pushed a commit
that referenced
this pull request
Dec 23, 2024
### What changes were proposed in this pull request? Optimize the code for `exists` and `find`. 1. Enhance the performance to lookup workerInfo by workerUniqueId instead of looping the collection: https://github.com/apache/celeborn/blob/74c1ec0a7fcc4d9efb26d9b96901234eb76e22cd/client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala#L65-L66 Change the type to: ``` type ShuffleAllocatedWorkers = ConcurrentHashMap[Int, ConcurrentHashMap[String, ShufflePartitionLocationInfo]] ``` And save the `WorkerInfo` into `ShufflePartitionLocationInfo`. ``` class ShufflePartitionLocationInfo(val workerInfo: WorkerInfo) { ... } ``` So that, we can get the `WorkerInfo` by worker uniqueId fast. 2. Reduce the loop cost for below code: https://github.com/apache/celeborn/blob/33ba0e02f56bfa032c02d1e41c52573c79661b1b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala#L455-L466 ### Why are the changes needed? Enhance the performance. Address comments: #2959 (review) #2959 (comment) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA Closes #2962 from turboFei/CELEBORN_1753_exists. Lead-authored-by: Wang, Fei <[email protected]> Co-authored-by: Fei Wang <[email protected]> Signed-off-by: Shuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup for #2905,
using the same logic to optimize
isAllMapTasksEndmethod.Why are the changes needed?
Address comments: #2905 (review)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Same logic with #2905