[CELEBORN-1740][CIP-14] Add stackTrace utils to cppClient #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FMX Could you kindly review this PR? Thanks a lot. |
|
Can you add some unit tests for this PR? |
|
@FMX It is hard to add uts to StackTrace util code along, as it is the building block for Exception utils in later commits. We could add uts when the exception utils are ready, what do you think? |
That sounds great to me. |
FMX
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds StackTrace utils code to CppClient.
Why are the changes needed?
To provide StackTrace utils.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Compilation.