[CELEBORN-1317][FOLLOWUP] ServerConnector supports celeborn.master.http.stopTimeout and celeborn.worker.http.stopTimeout #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tp.stopTimeout and celeborn.worker.http.stopTimeout
turboFei
approved these changes
Mar 31, 2024
RexXiong
approved these changes
Apr 1, 2024
CodingCat
pushed a commit
to CodingCat/incubator-celeborn
that referenced
this pull request
Apr 1, 2024
…tp.stopTimeout and celeborn.worker.http.stopTimeout ### What changes were proposed in this pull request? `ServerConnector` supports `celeborn.master.http.stopTimeout` and `celeborn.worker.http.stopTimeout`. ### Why are the changes needed? Jetty `Server` supports `celeborn.master.http.stopTimeout` and `celeborn.worker.http.stopTimeout`, but `ServerConnector` does not support, which default stop timeout is 5min. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Local test. Closes apache#2437 from SteNicholas/CELEBORN-1317. Authored-by: SteNicholas <[email protected]> Signed-off-by: Shuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ServerConnectorsupportsceleborn.master.http.stopTimeoutandceleborn.worker.http.stopTimeout.Why are the changes needed?
Jetty
Serversupportsceleborn.master.http.stopTimeoutandceleborn.worker.http.stopTimeout, butServerConnectordoes not support, which default stop timeout is 5min.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Local test.