address comments

apache · Dec 19, 2024 · b4c422e · b4c422e
1 parent dc66650
commit b4c422e
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 39 deletions.
diff --git a/.github/workflows/deps.yml b/.github/workflows/deps.yml
@@ -63,7 +63,7 @@ jobs:
       with:
         distribution: zulu
         java-version: 8
-        check-latest: false
+        check-latest: true
     - name: SBT Check dependency list
       run: |
         ./dev/dependencies.sh --sbt --module ${{ matrix.module }} --check
@@ -98,7 +98,7 @@ jobs:
         distribution: zulu
         java-version: 8
         cache: maven
-        check-latest: false
+        check-latest: true
     - name: Maven Check dependency list
       run: |
         ./dev/dependencies.sh --module ${{ matrix.module }} --check
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
@@ -69,9 +69,6 @@ jobs:
         run: |
           SPARK_BINARY_VERSION=${{ matrix.spark }}
           SPARK_MAJOR_VERSION=${SPARK_BINARY_VERSION%%.*}
-          if [[ $SPARK_MAJOR_VERSION == "3" ]]; then
-            SPARK_MAJOR_VERSION="3-4"
-          fi
           PROFILES="-Pgoogle-mirror,spark-${{ matrix.spark }}"
           TEST_MODULES="client-spark/common,client-spark/spark-${SPARK_MAJOR_VERSION},client-spark/spark-${SPARK_MAJOR_VERSION}-shaded,tests/spark-it"
           build/mvn $PROFILES -pl $TEST_MODULES -am clean install -DskipTests

diff --git a/client-spark/spark-4-columnar-shuffle/src/test/resources/log4j.properties b/client-spark/spark-4-columnar-shuffle/src/test/resources/log4j.properties
diff --git a/project/CelebornBuild.scala b/project/CelebornBuild.scala
@@ -813,7 +813,7 @@ object Spark35 extends SparkClientProjects {
 object Spark40 extends SparkClientProjects {
 
   val sparkClientProjectPath = "client-spark/spark-3-4"
-  val sparkClientProjectName = "celeborn-client-spark-3"
+  val sparkClientProjectName = "celeborn-client-spark-4"
   val sparkClientShadedProjectPath = "client-spark/spark-4-shaded"
   val sparkClientShadedProjectName = "celeborn-client-spark-4-shaded"