CAMEL-12478: Allow use of custom keyboard #2318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I separated in 5 commits, but when the review is done I should probably squash them up in one, right? |
WillemJiang
reviewed
May 6, 2018
| @@ -0,0 +1,53 @@ | |||
| package org.apache.camel.component.telegram.model; | |||
There was a problem hiding this comment.
Please add the License header here.
| @@ -0,0 +1,121 @@ | |||
| package org.apache.camel.component.telegram.model; | |||
willianantunes
force-pushed
the
telegram-custom-keyboard
branch
from
9bbb2e5 to
7cf6ca9
Compare
WillemJiang
reviewed
May 7, 2018
|
|
||
| [source,java] | ||
| --------------------------------------------------------- | ||
| from("telegram:bots/123456789:AAE_dLq5C19xwGjw3yiC2NvEUrZcejK21-Q987654321:AAE_dLq5C19xwOmg5yiC2NvSrkT3wj5Q1-L") |
There was a problem hiding this comment.
Please make sure you don't use a private bots, as the access key may be abused.
There was a problem hiding this comment.
I used the same access key available in the documentation. See other examples on it. This key is not mine.
There was a problem hiding this comment.
So it should be a random one I've generated (I hope 😄)
oscerd
approved these changes
May 8, 2018
|
LGTM now, @WillemJiang would you like to merge? |
|
Thanks, this has been merged on master. |
Croway
pushed a commit
to Croway/camel
that referenced
this pull request
Mar 14, 2024
Entesb 22164 713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here, it will permit the usage of custom keyboard in order to increase the interaction with the user as it's a lot easier to select an option instead of ask the user writing one.