Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @SessionScoped with @ApplicationScoped in Camel CXF #6888

Closed
llowinge opened this issue Jan 6, 2025 · 4 comments
Closed

Replace @SessionScoped with @ApplicationScoped in Camel CXF #6888

llowinge opened this issue Jan 6, 2025 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@llowinge
Copy link
Contributor

llowinge commented Jan 6, 2025

Bug description

As discussed in #6880 it looks we are using @SessionScoped at more places (https://github.com/search?q=repo%3Aapache%2Fcamel-quarkus%20%40SessionScoped&type=code). We should aim for @ApplicationScoped (or @RequestScope for special needs, but @SessionScoped acted as workaround only - there is no session in the camel cxf route, so it doesn't make sense to use it).

@llowinge
Copy link
Contributor Author

llowinge commented Jan 6, 2025

@jamesnetherton Can you assign me ?

@llowinge
Copy link
Contributor Author

llowinge commented Jan 6, 2025

First observation, using @RequestScoped is giving me

Caused by: jakarta.enterprise.context.ContextNotActiveException: RequestScoped context was not active when trying to obtain a bean instance for a client proxy of PRODUCER_METHOD bean [class=org.apache.camel.quarkus.component.cxf.soap.client.it.CxfSoapClientRoutes, id=XzFNO2ttWexJbzVIRqtS-_USgok]
	- you can activate the request context for a specific method using the @ActivateRequestContext interceptor binding

llowinge added a commit to llowinge/camel-quarkus that referenced this issue Jan 6, 2025
@llowinge
Copy link
Contributor Author

llowinge commented Jan 6, 2025

@jamesnetherton @ppalaga Would you be OK with sth like llowinge@7d75b22 ?

@jamesnetherton
Copy link
Contributor

Would you be OK with sth like llowinge@7d75b22 ?

From my POV, yes. It's the more correct solution.

llowinge added a commit to llowinge/camel-quarkus that referenced this issue Jan 7, 2025
llowinge added a commit to llowinge/camel-quarkus that referenced this issue Jan 7, 2025
llowinge added a commit to llowinge/camel-quarkus that referenced this issue Jan 7, 2025
llowinge added a commit to llowinge/camel-quarkus that referenced this issue Jan 7, 2025
llowinge added a commit to llowinge/camel-quarkus that referenced this issue Jan 7, 2025
llowinge added a commit to llowinge/camel-quarkus that referenced this issue Jan 7, 2025
@jamesnetherton jamesnetherton added this to the 3.18.0 milestone Jan 7, 2025
jamesnetherton pushed a commit to jamesnetherton/camel-quarkus that referenced this issue Jan 9, 2025
jamesnetherton pushed a commit to jamesnetherton/camel-quarkus that referenced this issue Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants