Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): allow specifying integration run sources exclusively via config file #5930

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix(cli): allow specifying integration run sources exclusively via config file #5930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a50acf
fix: allow specifying integration run sources exclusively via config …
fsrv-xyz Nov 7, 2024
b041f17
fix: adjust length check of sources defined in config file
fsrv-xyz Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ func (o *runCmdOptions) run(cmd *cobra.Command, args []string) error {
}

// We need to make this check at this point, in order to have sources filled during decoding
if len(args) < 1 && o.ContainerImage == "" {
if (len(args) < 1 && len(o.Sources) < 1) && o.ContainerImage == "" {
return errors.New("run command expects either an Integration source or the container image (via --image argument)")
}

Expand Down