Bugfix/5758 incremental image build fix #5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Unit test coverage report - coverage increased from 42.9% to 43% (+0.1%) |
squakez
approved these changes
Aug 16, 2024
lsergio
force-pushed
the
bugfix/5758-incrementalImageBuildFix
branch
from
0fa293d to
b8d5acf
Compare
|
✔️ Unit test coverage report - coverage increased from 42.9% to 43% (+0.1%) |
… compatible with the incremental image build algorithm
lsergio
force-pushed
the
bugfix/5758-incrementalImageBuildFix
branch
from
b8d5acf to
db8c0fa
Compare
|
I see some e2e tests have failed. I'm trying to run the failed tests locally to see what needs to be fixed, but this will probably take some time... |
lsergio
force-pushed
the
bugfix/5758-incrementalImageBuildFix
branch
5 times, most recently
from
ec7d931 to
7ef2d96
Compare
…application jar when matching dependencies
lsergio
force-pushed
the
bugfix/5758-incrementalImageBuildFix
branch
from
7ef2d96 to
b9bf1be
Compare
|
Added b9bf1be to the PR. The image reuse algorithm was considering the application jar file as a dependency. As each integration generates its own jar file with the same name, but different checksum, there would never be a match and we would always use the root image as base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for solving the bug reported in #5758.
The main idea is that the incremental image build algorithm will select the base image that has more dependencies among those required by the new image, but no extra ones.
Also, the logic in build_type_support.go has changed to be compatible with this approach. The matching build will be the one with more common dependencies, but no extra ones.
Closes #5758
Once approved, I can backport this to release-4.x as well.
Release Note