chore: update golagci-lint to v1.158.0 #5471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 8, 2024
squakez
approved these changes
May 8, 2024
.golangci.yml
Outdated
| @@ -73,3 +74,7 @@ linters: | |||
| - whitespace | |||
| - wrapcheck | |||
| - wsl | |||
| - execinquery | |||
| # TODO: too much work at this stage, but they should be re-enabled | |||
There was a problem hiding this comment.
Just out of curiosity. What this comment exactly mean?
There was a problem hiding this comment.
I have improved it a little bit the description
TL;DR; fixing the warning would have required to change a lot of files so I'll open some new issues to track the tasks once this gets merged.
lburgazzoli
force-pushed
the
golancilint-1.58
branch
from
0d95f03 to
b6fdbb4
Compare
lburgazzoli
force-pushed
the
golancilint-1.58
branch
from
b6fdbb4 to
15cd897
Compare
|
@squakez do we have already a PR/commit for the security finding ? |
No, it should eventually fixed automatically when the golang action will move to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note