-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trait): let camel framework manage Kamelets #4797
Conversation
We use the mechanism expected by Camel runtime framework to manage Kamelets at runtime
🐫 Thank you for contributing! Code Coverage Report |
🐫 Thank you for contributing! Code Coverage Report ✔️ - Coverage unchanged. |
🐫 Thank you for contributing! Code Coverage Report |
1 similar comment
🐫 Thank you for contributing! Code Coverage Report |
🐫 Thank you for contributing! Code Coverage Report |
1 similar comment
🐫 Thank you for contributing! Code Coverage Report |
@christophd the Yaks check is failing because we need to provide the dependencies when creating a Kamelet. Is there any way to do that easily in
dependencies parameter, is it?
|
🐫 Thank you for contributing! Code Coverage Report |
🐫 Thank you for contributing! Code Coverage Report |
I think there is a way to also add dependencies to the YAKS step. But maybe it is better to not use |
I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are there any other side effects of this? |
Yes, this is a valid point, thanks. I overlooked this part as we miss any test validating such feature. We need, at least, to parse the inner logic of kamelets in order to discover "capabilities" of any sort beside dependencies. I'll see how we can include this as well and include a test in order to validate the feature. |
🐫 Thank you for contributing! Code Coverage Report |
Parsing is now done in #4812 which supersedes this PR. Basically we maintain the generated source in order to perform any parsing as we used to do, but, we do not mount such sources. We instead create a Kamelet bundle configmap which is mounted under ''/etc/camel/kamelets` and let the runtime to use such Kamelets as it normally does in plain Camel. |
With this PR we get rid off the very first Kamelets runtime execution which translated the Kamelets into a route templates. We let now the Camel runtime to use the Kamelets as they are expected in the framework.
Closes #4618
Release Note