Skip to content

Commit

Permalink
feat(helm): align resources for helm
Browse files Browse the repository at this point in the history
Until now we were maintaining 2 separate set of installation resources. Here we make Helm to reuse the existing base resources instead, making easier any future evolution
  • Loading branch information
squakez committed Dec 7, 2024
1 parent 8870a49 commit 56a7531
Show file tree
Hide file tree
Showing 21 changed files with 788 additions and 489 deletions.
2 changes: 1 addition & 1 deletion e2e/install/helm/setup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import (
func TestHelmInstallation(t *testing.T) {
WithNewTestNamespace(t, func(ctx context.Context, g *WithT, ns string) {
containerRegistry, ok := os.LookupEnv("KAMEL_INSTALL_REGISTRY")
g.Expect(ok).To(BeTrue(), "This test requires setting KAMEL_INSTALL_REGISTRY variable.")
g.Expect(ok).To(BeTrue(), "You must provide a registry address in KAMEL_INSTALL_REGISTRY env variable")
// Let's make sure no CRD is yet available in the cluster
// as we must make the procedure to install them accordingly
g.Eventually(CRDs(t)).Should(BeNil(), "No Camel K CRDs should be previously installed for this test")
Expand Down
3 changes: 1 addition & 2 deletions e2e/support/test_support.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ const ExpectedKubePromoteRoles = 7
// camel-k-edit
// camel-k-operator-custom-resource-definitions
// camel-k-operator-bind-addressable-resolver
// camel-k-operator-local-registry
const ExpectedKubeClusterRoles = 4
const ExpectedKubeClusterRoles = 3

// camel-k-operator-openshift
const ExpectedOSPromoteRoles = 1
Expand Down
File renamed without changes.
196 changes: 0 additions & 196 deletions helm/camel-k/templates/operator-cluster-role-bindings.yaml

This file was deleted.

File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,12 @@ metadata:
annotations:
{{ toYaml . | nindent 4 }}
{{- end }}

---

apiVersion: v1
kind: ServiceAccount
metadata:
name: camel-k-builder
labels:
app: "camel-k"
Loading

0 comments on commit 56a7531

Please sign in to comment.