Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Reformat CONCAT_WS and REVERSE document #4075

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

strongduanmu
Copy link
Member

In reference document - https://calcite.apache.org/docs/reference.html#dialect-specific-operators, CONCAT_WS and REVERSE functions had rendering problems because their syntax included | without using escape characters.

  • CONCAT_WS:
image
  • REVERSE:
image

Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know when the site is re-rendered. Is it on a new release or on every commit?

@strongduanmu
Copy link
Member Author

I don't know when the site is re-rendered. Is it on a new release or on every commit?

According to https://github.com/apache/calcite/blob/main/site/README.md, calcite will automatically publish based on the changes in the main branch.

@NobiGo
Copy link
Contributor

NobiGo commented Dec 3, 2024

It would be helpful if there were a screenshot after applying this PR.

@strongduanmu
Copy link
Member Author

It would be helpful if there were a screenshot after applying this PR.

@NobiGo Thank you for your good suggestion. I generated a new doc locally and the rendering results are as follows:

  • CONCAT_WS:
image
  • REVERSE:
image

@NobiGo
Copy link
Contributor

NobiGo commented Dec 4, 2024

@strongduanmu How about we change the commit info to Site: Reformat CONCAT_WS and REVERSE document. Maintain consistency with the previous style.

@caicancai
Copy link
Member

@strongduanmu How about we change the commit info to Site: Reformat CONCAT_WS and REVERSE document. Maintain consistency with the previous style.

+1

@caicancai
Copy link
Member

caicancai commented Dec 4, 2024

I don't know when the site is re-rendered. Is it on a new release or on every commit?

My last change to the document doesn't seem to have taken effect on the official website yet
https://issues.apache.org/jira/browse/CALCITE-6613

@strongduanmu strongduanmu changed the title Add escape characters to solve CONCAT_WS and REVERSE document render problem Site: Reformat CONCAT_WS and REVERSE document Dec 5, 2024
@strongduanmu
Copy link
Member Author

@strongduanmu How about we change the commit info to Site: Reformat CONCAT_WS and REVERSE document. Maintain consistency with the previous style.

@NobiGo Thank you for your good suggestion, I have modified the commit info.

Copy link

sonarcloud bot commented Dec 5, 2024

@NobiGo
Copy link
Contributor

NobiGo commented Dec 5, 2024

Thanks for the contribution @strongduanmu .

@NobiGo NobiGo merged commit 92cf3dd into apache:main Dec 5, 2024
4 checks passed
@strongduanmu strongduanmu deleted the dev-doc-optimize branch December 5, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants