[CALCITE-4345] NPE in AggregateCaseToFilterRule when converts SUM(CASE WHEN c THEN 1 END) (Jiatao Tao) #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianhyde
reviewed
Oct 19, 2020
Aaaaaaron
force-pushed
the
CALCITE-4345
branch
from
4821c43 to
08aac8c
Compare
Aaaaaaron
changed the title
Aaaaaaron
force-pushed
the
CALCITE-4345
branch
from
08aac8c to
70b6982
Compare
liyafan82
reviewed
Oct 21, 2020
core/src/main/java/org/apache/calcite/rel/rules/AggregateCaseToFilterRule.java
Outdated
Show resolved
Hide resolved
Aaaaaaron
force-pushed
the
CALCITE-4345
branch
from
70b6982 to
bb8b914
Compare
julianhyde
reviewed
Oct 22, 2020
core/src/main/java/org/apache/calcite/rel/rules/AggregateCaseToFilterRule.java
Outdated
Show resolved
Hide resolved
…E WHEN c THEN 1 END) (Jiatao Tao)
Aaaaaaron
force-pushed
the
CALCITE-4345
branch
from
bb8b914 to
77f763f
Compare
julianhyde
pushed a commit
that referenced
this pull request
Nov 3, 2020
…when converting CASE without ELSE (Jiatao Tao) For example, 'SUM(CASE WHEN b THEN 1 END)' is equivalent to 'SUM(CASE WHEN b THEN 1 ELSE NULL END)', and both should be converted to 'SUM(1) FILTER (WHERE b)', but before this bug was fixed the former would throw NullPointerException. Close #2225
MalteBellmann
pushed a commit
to caespes/calcite
that referenced
this pull request
Feb 21, 2021
…when converting CASE without ELSE (Jiatao Tao) For example, 'SUM(CASE WHEN b THEN 1 END)' is equivalent to 'SUM(CASE WHEN b THEN 1 ELSE NULL END)', and both should be converted to 'SUM(1) FILTER (WHERE b)', but before this bug was fixed the former would throw NullPointerException. Close apache#2225
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/calcite
that referenced
this pull request
Jul 14, 2021
…when converting CASE without ELSE (Jiatao Tao) For example, 'SUM(CASE WHEN b THEN 1 END)' is equivalent to 'SUM(CASE WHEN b THEN 1 ELSE NULL END)', and both should be converted to 'SUM(1) FILTER (WHERE b)', but before this bug was fixed the former would throw NullPointerException. Close apache#2225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-4345