[CALCITE-3881][avatica] DateTimeUtils#addMonths yields incorrect resu… #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docete
changed the title
…lts in some corner case
danny0405
reviewed
Mar 31, 2020
| if (month < 1 || month > 12) { | ||
| throw new IllegalArgumentException( | ||
| "Month of any date on the Gregorian should between 1 to 12, but " + month); | ||
| } |
There was a problem hiding this comment.
We should add some negative tests.
There was a problem hiding this comment.
negative tests for addMonths?
See checkAddMonths(2019, 9, 1, 2016, 8, 1, -37);
There was a problem hiding this comment.
You should fix the throws of the test.
There was a problem hiding this comment.
Seems the throws come from old calcite since apache/calcite#1890 is not merged.
julianhyde
pushed a commit
to julianhyde/calcite-avatica
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lts in some corner case
DateTimeUtils#addMonths use DateTimeUtils#ymdToUnixDate to calculate the JDN(julian day number). But in some corner cases it yields incorrent results. The root cause is: the algorithm of DateTimeUtils#ymdToUnixDate requires reasonable month(1 to 12)[1], but SqlFunctions#addMonths may pass in a month out of the reasonable range. This PR will fix it.