Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Fix: recover command doesn't accept rate limit parameter #4535

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[cli] Fix: recover command doesn't accept rate limit parameter #4535

wants to merge 2 commits into from

Conversation

dlg99
Copy link
Contributor

@dlg99 dlg99 commented Dec 10, 2024 •
edited
Loading

Descriptions of the changes in this PR:

Motivation

Running recover command with rate limit like

bin/bookkeeper shell recover -rate 10000 <the rest of the params>

produces error

The provided bookie dest 10000 will be ignored!
ERROR: invalid value for option replicationRate : null

Changes

Fixed the bug, added tests.

@dlg99 dlg99 changed the title [cli] Fix: recover command didn't accept rate limit parameter [cli] Fix: recover command doesn't accept rate limit parameter Dec 10, 2024
@dlg99 dlg99 added this to the 4.18.0 milestone Dec 10, 2024
eolivelli
eolivelli approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

lhotari
lhotari approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@lhotari lhotari lhotari approved these changes

Assignees
No one assigned
Labels
release/4.16.7 release/4.17.2
Projects
None yet
Milestone
4.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dlg99 @lhotari @eolivelli