Release readBuffer when close BufferedReadChannel & BufferedChannel
#4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested changes
Jul 17, 2023
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
Outdated
Show resolved
Hide resolved
hangc0276
requested review from
dlg99,
eolivelli,
zymap,
wenbingshen and
StevenLuMT
hangc0276
approved these changes
Aug 9, 2023
| } | ||
|
|
||
| readBufferStartPosition = Long.MIN_VALUE; | ||
| readBuffer.release(); |
There was a problem hiding this comment.
We'd better use ReferenceCountUtil.release(readBuffer); instead of readBuffer.release();
There was a problem hiding this comment.
Thanks for review, fixed.
zymap
requested changes
Dec 4, 2023
Comment on lines
+105
to
+106
| super.close(); | ||
| writeBufferStartPosition.set(0); |
There was a problem hiding this comment.
Should we close and reset the position after setting the closed to true?
| @@ -899,6 +899,7 @@ private BufferedReadChannel getChannelForLogId(long entryLogId) throws IOExcepti | |||
| // We set the position of the write buffer of this buffered channel to Long.MAX_VALUE | |||
| // so that there are no overlaps with the write buffer while reading | |||
| fc = new BufferedReadChannel(newFc, conf.getReadBufferBytes()); | |||
|
|
|||
|
|
||
| // BufferedReadChannel is not response for fileChannel close. | ||
|
|
||
| closed = true; |
There was a problem hiding this comment.
Move the closed to the first step?
gaozhangmin
pushed a commit
to gaozhangmin/bookkeeper
that referenced
this pull request
Feb 20, 2024
dlg99
reviewed
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release readBuffer when close
BufferedReadChannel&BufferedChannelBufferedChannel is subclass of BufferedReadChannel, which will create a readBuffer to cache read content.
When close BufferedChannel, the readBuffer should be released to avoid memory leak.