Fix getLedgerDirsListener #4015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun failure checks |
|
rerun failure checks |
hangc0276
requested changes
Jul 17, 2023
...r/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java
Outdated
Show resolved
Hide resolved
hangc0276
requested review from
dlg99,
eolivelli,
zymap,
wenbingshen and
StevenLuMT
added 2 commits
July 17, 2023 18:13
|
@hangc0276 PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ledgerDirsListener in SingleDirectoryDbLedgerStorage is currently triggered by a ledger directory that does not belong to this storage.
Changes
To address this issue, we can introduce a comparison step to verify the ownership of the ledger directory before triggering the listeners. This way, the ledgerDirsListener will only be triggered for the directories that are associated with the storage.