Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7746] Add python type hints (part 1) #9915

Merged
merged 17 commits into from
Dec 11, 2019
Merged

[BEAM-7746] Add python type hints (part 1) #9915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a348e6e
Add tests for Timestamp/Duration comparisons
chadrik Oct 8, 2019
effe225
Ignore some conditional imports in tests
chadrik Sep 9, 2019
00c6ff7
Ignore functions missing from typeshed
chadrik Sep 9, 2019
f8eaf35
Ignore some objects missing from typeshed
chadrik Sep 8, 2019
60dac7b
Ignore some monkey-patching for tests
chadrik Oct 16, 2019
7814c08
Ignore an issue regarding asymmetrical property getter/setter
chadrik Sep 9, 2019
95d7618
Ignore unavoidable errors
chadrik Sep 9, 2019
928e9a0
Ignore a difficult scenario where None is sometimes unsafe
chadrik Oct 23, 2019
70f06ed
Address issues with a few missing modules/objects
chadrik Jul 28, 2019
c697caf
Ignore errors about dynamic base classes
chadrik Oct 16, 2019
58df66f
Add a mypy lint job
chadrik Oct 25, 2019
79744db
Consolidate python build requirements
chadrik Oct 20, 2019
bfd04a1
Add type annotations to bulk of python codebase
chadrik Oct 29, 2019
92bf5f6
Workaround a bug in pylint
chadrik Oct 25, 2019
18578d8
Silence errors about overriding methods.
chadrik Oct 29, 2019
6d2a801
Address review notes
chadrik Nov 25, 2019
5c48091
Rebase fixup
chadrik Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ sdks/java/maven-archetypes/examples-java8/src/main/resources/archetype-resources
**/dist/**/*
**/distribute-*/**/*
**/env/**/*
**/.mypy_cache
**/.dmypy.json
sdks/python/**/*.c
sdks/python/**/*.so
sdks/python/**/*.egg
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,7 +1773,7 @@ class BeamModulePlugin implements Plugin<Project> {
project.exec { commandLine virtualenvCmd }
project.exec {
executable 'sh'
args '-c', ". ${project.ext.envdir}/bin/activate && pip install --retries 10 --upgrade tox==3.11.1 grpcio-tools==1.3.5"
args '-c', ". ${project.ext.envdir}/bin/activate && pip install --retries 10 --upgrade tox==3.11.1 -r ${project.rootDir}/sdks/python/build-requirements.txt"
}
}
// Gradle will delete outputs whenever it thinks they are stale. Putting a
Expand Down
2 changes: 2 additions & 0 deletions sdks/python/.pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ disable =
unnecessary-lambda,
unnecessary-pass,
unneeded-not,
unsubscriptable-object,
unused-argument,
unused-wildcard-import,
useless-object-inheritance,
Expand Down Expand Up @@ -178,6 +179,7 @@ indent-after-paren=4
ignore-long-lines=(?x)
(^\s*(import|from)\s
|^\s*(\#\ )?<?(https?|ftp):\/\/[^\s\/$.?#].[^\s]*>?$
|# type:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line disabled line-too-long errors across the board: https://issues.apache.org/jira/browse/BEAM-9058.

)

[VARIABLES]
Expand Down
Loading