Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-2964] Exclude incompatible six release. #3865

Closed
wants to merge 2 commits into from
Closed

[BEAM-2964] Exclude incompatible six release. #3865

wants to merge 2 commits into from

Conversation

robertwb
Copy link
Contributor

Upstream bugs being tracked at google/apitools#175 and benjaminp/six#210

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@robertwb
Copy link
Contributor Author

R: @tgroh

tgroh
tgroh approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@tgroh tgroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 5dab9e1 Sep 19, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 45ccb1a on robertwb:BEAM-2964-six into ** on apache:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 45ccb1a on robertwb:BEAM-2964-six into ** on apache:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgroh tgroh tgroh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertwb @coveralls @tgroh