-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update allowed lateness in FixedWindows example to 2 days #34227
base: master
Are you sure you want to change the base?
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title is misleading.
It might be better to be something like "fix typo in xxxx python Docs"
Please fix https://github.com/apache/beam/actions/runs/13768255852/job/38504359945?pr=34227 py3-yapf-check: commands[1]> time yapf --diff --parallel --recursive apache_beam
Command exited with non-zero status 1 |
@liferoad can you suggest any specific commands so that i can run it locally and test it. |
@Brijeshthummar02 make sure you used Google python formatter (https://github.com/google/yapf) to format your code. |
@mataralhawiti just to mention i have used this to check
and this to automatically fix the formatting issues
and it formated 798 py files just to mention should i make commit by adding all files formatted?? |
I usually do this with my own venv:
|
@liferoad your point makes sense, but what i think using
will like format our whole repo that should be good call, should we try - if yes i can commit it. |
and this was results of what you suggested
|
which python are you using? |
Python 3.13.2 |
Try python 3.12 or 3.11 |
Please add a meaningful description for your change here
fixes #34224
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.