Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostCommit Java DataflowV2 #34209

Merged
merged 5 commits into from
Mar 8, 2025
Merged

Fix PostCommit Java DataflowV2 #34209

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbc0cd1
Skip some tests on Dataflow runners
akashorabek Mar 7, 2025
4a81e70
run spotless
akashorabek Mar 7, 2025
d1cc295
changed to assumeFalse
akashorabek Mar 7, 2025
b8dddc5
format comments
akashorabek Mar 8, 2025
f9d6400
add message to assumeFalse
akashorabek Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions ...tform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assume.assumeFalse;
import static org.junit.Assume.assumeTrue;

import com.google.api.services.bigquery.model.Table;
Expand Down Expand Up @@ -372,8 +373,8 @@ private void runStreamingPipelineWithSchemaChange(
// Only run the most relevant test case on Dataflow
if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
assumeTrue(
"Skipping in favor of more relevant test case",
changeTableSchema && useInputSchema && useAutoSchemaUpdate);
"Skipping in favor of more relevant test case and to avoid timing issues",
!changeTableSchema && useInputSchema && useAutoSchemaUpdate);
}

List<String> fieldNamesOrigin = new ArrayList<String>(Arrays.asList(FIELDS));
Expand Down Expand Up @@ -618,11 +619,11 @@ public void runDynamicDestinationsWithAutoSchemaUpdate(boolean useAtLeastOnce) t
// Need to manually enable streaming engine for legacy dataflow runner
ExperimentalOptions.addExperiment(
p.getOptions().as(ExperimentalOptions.class), GcpOptions.STREAMING_ENGINE_EXPERIMENT);
// Only run the most relevant test case on Dataflow
if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
assumeTrue(
"Skipping in favor of more relevant test case", changeTableSchema && useInputSchema);
}
// Skipping dynamic destinations tests on Dataflow because of timing issues
// These tests are more stable on the DirectRunner, where timing is less variable
assumeFalse(
"Skipping dynamic destinations tests on Dataflow because of timing issues",
p.getOptions().getRunner().getName().contains("DataflowRunner"));

List<String> fieldNamesOrigin = new ArrayList<String>(Arrays.asList(FIELDS));

Expand Down
Loading