Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retry count assertion from testInvalidRecordReceived #34192

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

akashorabek
Copy link
Collaborator

@akashorabek akashorabek commented Mar 6, 2025

Fixes: #34173
Removed the assertion from testInvalidRecordReceived because it's acceptable for the test to show more than 2 retries. The error happens after the call returns a bad result, not during the call itself, so each retry counts as a full request. I think this behavior is expected and doesn't indicate a problem with the retry logic.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@akashorabek
Copy link
Collaborator Author

R: @Abacn

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit 5bb7cf5 into apache:master Mar 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants