Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preempt issubclass error for generic types #33995

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

msuozzo
Copy link
Contributor

@msuozzo msuozzo commented Feb 14, 2025

Previously, parameterized generics that made it to the issubclass call would
fail and cause obscure stack traces to bubble up. Short-circuiting this logic
by unconditionally rejecting ensures the type check failure case will handle
the error message generation and display.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Previously, parameterized generics that made it to the issubclass call would
fail and cause obscure stack traces to bubble up. Short-circuiting this logic
by unconditionally rejecting ensures the type check failure case will handle
the error message generation and display.
@msuozzo
Copy link
Contributor Author

msuozzo commented Feb 16, 2025

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor

R: @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jrmccluskey jrmccluskey merged commit d436d02 into apache:master Feb 25, 2025
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants