Make use staged sdk harness effective whenever experiment flag added #33954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abacn
force-pushed
the
staged-harness
branch
from
db4770d to
b53ea9e
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
R: @tvalentyn internal context - b/394923242#comment3 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
R: @shunping |
tvalentyn
approved these changes
Feb 13, 2025
tvalentyn
reviewed
Feb 13, 2025
| if !hasWorkerExperiment { | ||
| cp = append(cp, filepath.Join(jarsDir, javaHarnessJar)) | ||
| } else { | ||
| // Skip adding system "beam-sdks-java-harness.jar". User-provided jar will |
There was a problem hiding this comment.
for my education, is this internal-only flow?
There was a problem hiding this comment.
external user could also use it. The purpose is detailed in the description of #33508users without docker access could test/run custom build beam-sdk-harness now
tvalentyn
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33508 supported use staged sdk harness, however, it is only effective when a staged jar named after beam-sdks-java-harness*.jar. In. the case a uber jar is used, the flag isn't effective.
This change will make the flag effective regardless the staged jar file names.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.