[Dataflow Streaming] Optimize WindmillStateUtil.encodeKey by appending directly to ByteStringOutputStream #33735
+95
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gAppendable OutputStreamWriter is thread safe and has synchronization overhead. Each OutputStreamWriter allocates a 512 byte buffer which is useful when writing inmemory ByteStrings.
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
arunpandianp
changed the title
|
Run Java PreCommit |
scwhittle
requested changes
Jan 23, 2025
.../src/main/java/org/apache/beam/runners/dataflow/worker/util/common/ByteStringAppendable.java
Outdated
Show resolved
Hide resolved
scwhittle
approved these changes
Jan 24, 2025
|
Run Java PerCommit |
|
Run Java PreCommit |
|
needs resolving |
|
resolved conflicts |
scwhittle
changed the title
scwhittle
changed the title
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
scwhittle
approved these changes
Jan 29, 2025
|
unrelated failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutputStreamWriter is thread safe and has synchronization overhead. Each OutputStreamWriter allocates a 512 byte buffer which is not useful when writing in-memory ByteStrings.
The buffer allocations show up starkly on cpu profiles.
#33578