Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#31438] WindowingStrategy Plumbing + AllowedLateness + Fixing Session Windows #33542

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Jan 8, 2025

One thing lead to another with this so this PR does a few related things.

  • Exports the windowing strategy struct to configure aggregation stages in the element manager.
    • This is prep-work for fully supporting the rest of the windowing strategies + triggers.
  • Uses the above to support AllowedLateness.
  • In doing so, it was noted that incorrect conversions from integers (representing durations of nanosecond precision) to mtime.Time which is strictly a millisecond duration. This fix revealed two issues with Session Windows.
  • Fixes to Session Window Merging
    • Merging wasn't correctly happening per key. Windows were being treated "globally".
    • We were incorrectly using the GapSize in prism. GapSize was already accounted for in the generation of the SessionWindow's interval Window representation.
    • These fixes resolved the issue that [prism] PrismRunnerTest::test_windowing - session windowing failing. #32085 was filed for, so the re-written Python test could be removed.
  • Late data is now only dropped before aggregations, when it matters most.
    • This avoids a correctness issue dropping data in a Reshuffle.
    • This will be re-evaluated as windowing strategies are implemented, but it's better to have more tests enabled, so they can provide a signal.

Part of #31438


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Contributor Author

lostluck commented Jan 8, 2025

R: @damondouglas

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@lostluck
Copy link
Contributor Author

lostluck commented Jan 9, 2025

Failures are unrelated to the PR. Merging.

@lostluck lostluck merged commit 4fc5c86 into apache:master Jan 9, 2025
106 of 108 checks passed
@lostluck lostluck deleted the winStratPlumbing branch January 9, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants