Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix republish docker branch #33501

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix republish docker branch #33501

merged 3 commits into from
Jan 6, 2025

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jan 6, 2025

This workflow was failing because it doesn't auto-pick up the defaults if triggered via schedule, it only uses the defaults for workflow dispatch. This meant the release/rc variables weren't getting set.

This fixes the problem and gets checkout running correctly (example). There is a good chance the workflow will still fail because all of our docker tasks are currently flaky due to #33425 but the core workflow logic should be good


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jan 6, 2025
@damccorm
Copy link
Contributor Author

damccorm commented Jan 6, 2025

R: @claudevdm

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm damccorm merged commit 28999bc into master Jan 6, 2025
3 of 4 checks passed
@damccorm damccorm deleted the users/damccorm/fixBranch branch January 6, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants