Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xlang kinesis to v2 #33416

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Update xlang kinesis to v2 #33416

wants to merge 44 commits into from

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Dec 18, 2024

We are actively removing the v1 AWS IOs, so we need to move the x-lang version to use v2. I tried to make this change in as non-breaking a way as possible, but there are differences across the IOs (e.g. not supporting producer properties), which should cause the current users to break/respond.

Part of #33430


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.43%. Comparing base (7c86bf3) to head (60c2480).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/io/kinesis.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33416      +/-   ##
============================================
- Coverage     57.46%   57.43%   -0.04%     
  Complexity     1475     1475              
============================================
  Files           979      980       +1     
  Lines        155332   155312      -20     
  Branches       1076     1076              
============================================
- Hits          89255    89196      -59     
- Misses        63864    63900      +36     
- Partials       2213     2216       +3     
Flag Coverage Δ
python 81.24% <50.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -64,7 +64,7 @@
DockerContainer = None
# pylint: enable=wrong-import-order, wrong-import-position, ungrouped-imports

LOCALSTACK_VERSION = '0.11.3'
LOCALSTACK_VERSION = '3.8.1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New aws ios didn't seem to work with old localstack, so I had to update this and some of the other things in this file.

@damccorm damccorm changed the title [WIP] Update xlang kinesis to v2 Update xlang kinesis to v2 Dec 27, 2024
@damccorm damccorm marked this pull request as ready for review December 27, 2024 16:26
@damccorm
Copy link
Contributor Author

damccorm commented Dec 27, 2024

@aromanenko-dev FYI, here is the first PR to remove V1 IOs. This is the most involved, the others are mostly just cutting out code. (I'll let the bot assign reviewers in case you are unavailable for the holidays 😄)

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damccorm
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.
R: @kennknowles for label java.
R: @Abacn for label build.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant