-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xlang kinesis to v2 #33416
base: master
Are you sure you want to change the base?
Update xlang kinesis to v2 #33416
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33416 +/- ##
============================================
- Coverage 57.46% 57.43% -0.04%
Complexity 1475 1475
============================================
Files 979 980 +1
Lines 155332 155312 -20
Branches 1076 1076
============================================
- Hits 89255 89196 -59
- Misses 63864 63900 +36
- Partials 2213 2216 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -64,7 +64,7 @@ | |||
DockerContainer = None | |||
# pylint: enable=wrong-import-order, wrong-import-position, ungrouped-imports | |||
|
|||
LOCALSTACK_VERSION = '0.11.3' | |||
LOCALSTACK_VERSION = '3.8.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New aws ios didn't seem to work with old localstack, so I had to update this and some of the other things in this file.
@aromanenko-dev FYI, here is the first PR to remove V1 IOs. This is the most involved, the others are mostly just cutting out code. (I'll let the bot assign reviewers in case you are unavailable for the holidays 😄) |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
We are actively removing the v1 AWS IOs, so we need to move the x-lang version to use v2. I tried to make this change in as non-breaking a way as possible, but there are differences across the IOs (e.g. not supporting producer properties), which should cause the current users to break/respond.
Part of #33430
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.