Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve existing Python multi-lang SchemaTransform examples #33361

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

ahmedabu98
Copy link
Contributor

@ahmedabu98 ahmedabu98 commented Dec 11, 2024

Part of #33358

Simplify the Python example, and refactor the Java SchemaTransforms to be consistent

@ahmedabu98 ahmedabu98 marked this pull request as ready for review December 12, 2024 19:29
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as the Python changes are concerned

@github-actions github-actions bot added python and removed python labels Dec 18, 2024
@ahmedabu98 ahmedabu98 merged commit 8fee3ca into apache:master Dec 19, 2024
87 of 92 checks passed
ahmedabu98 added a commit that referenced this pull request Dec 19, 2024
* improve python multi-lang examples

* minor adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add new Python SchemaTransform multi-language documentation
2 participants