Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yaml] various inline provider doc fixes #33296

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Dec 5, 2024

Fixing a couple formatting issues with various providers.

  • add args to Combine doc
  • StripErrorMetadata code was not in code block
  • StripErrorMetadata ignore super class (PTransform) args (label)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Polber
Copy link
Contributor Author

Polber commented Dec 5, 2024

R: @robertwb

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.42%. Comparing base (a9a82a1) to head (a313bc6).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #33296   +/-   ##
=========================================
  Coverage     57.41%   57.42%           
  Complexity     1474     1474           
=========================================
  Files           970      970           
  Lines        154498   154500    +2     
  Branches       1076     1076           
=========================================
+ Hits          88708    88715    +7     
+ Misses        63586    63581    -5     
  Partials       2204     2204           
Flag Coverage Δ
python 81.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -453,6 +453,9 @@ class _StripErrorMetadata(beam.PTransform):

_ERROR_FIELD_NAMES = ('failed_row', 'element', 'record')

def __init__(self):
super().__init__(label=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this needed?

@robertwb robertwb merged commit 0bf6f69 into apache:master Dec 6, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants