-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable managed service in Python tests #33190
Enable managed service in Python tests #33190
Conversation
…le_managed_service_tests
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Looks like the test failure is still there/the file is not getting auto-created |
Yep the test relies on the connector to create the table dynamically. This feature is present in 2.61.0 (and HEAD), but Managed Iceberg version is pinned at 2.60.0. We can wait and rerun the tests when 2.61.0 is released and Managed Iceberg version is bumped accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - that makes sense. Approving conditional on us getting that green signal
Reminder, please take a look at this pr: @jrmccluskey @damccorm |
…le_managed_service_tests
The service config version was bumped and tests are green now! will merge |
Awesome - thanks! |
No description provided.