Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable managed service in Python tests #33190

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

ahmedabu98
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the build label Nov 22, 2024
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor

Looks like the test failure is still there/the file is not getting auto-created

@ahmedabu98
Copy link
Contributor Author

Yep the test relies on the connector to create the table dynamically. This feature is present in 2.61.0 (and HEAD), but Managed Iceberg version is pinned at 2.60.0.

We can wait and rerun the tests when 2.61.0 is released and Managed Iceberg version is bumped accordingly.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - that makes sense. Approving conditional on us getting that green signal

Copy link
Contributor

Reminder, please take a look at this pr: @jrmccluskey @damccorm

@ahmedabu98
Copy link
Contributor Author

The service config version was bumped and tests are green now! will merge

@ahmedabu98 ahmedabu98 merged commit 89ae2c1 into apache:master Dec 6, 2024
94 checks passed
@damccorm
Copy link
Contributor

damccorm commented Dec 6, 2024

Awesome - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants