Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#33145 cache namespace string key in FlinkStateInternals #33146

Merged
merged 1 commit into from
Nov 20, 2024
+64 −69
Merged

#33145 cache namespace string key in FlinkStateInternals #33146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/trigger_files/beam_PostCommit_Java_Nexmark_Flink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"runFor": "#33146"
}
3 changes: 1 addition & 2 deletions .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Flink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
"https://github.com/apache/beam/pull/32648": "testing addition of Flink 1.19 support"
"runFor": "#33146"
}
4 changes: 2 additions & 2 deletions runners/core-java/src/main/java/org/apache/beam/runners/core/StateNamespaces.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ public void appendTo(Appendable sb) throws IOException {
/** {@link StateNamespace} that is scoped to a specific window. */
public static class WindowNamespace<W extends BoundedWindow> implements StateNamespace {

private Coder<W> windowCoder;
private W window;
private final Coder<W> windowCoder;
private final W window;

private WindowNamespace(Coder<W> windowCoder, W window) {
this.windowCoder = windowCoder;
Expand Down
Loading
Loading