Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yaml] add mysql, oracle, postgres and sql server providers #33124

Merged
merged 6 commits into from
Dec 29, 2024
+854 −161
Merged

[yaml] add mysql, oracle, postgres and sql server providers #33124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3c906f
[yaml] add JDBC docs
Polber Nov 12, 2024
ac6a59b
Address comments
Polber Nov 20, 2024
4cfc96b
remove baseDescription
Polber Nov 27, 2024
c93df87
fix spotless
Polber Nov 27, 2024
bb28a32
fix failing tests
Polber Dec 4, 2024
1bfa344
remove hikari testImplementation for JDBCIO
Polber Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 23 additions & 31 deletions .../src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadSchemaTransformProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,40 +76,34 @@ public String description() {
+ "\n"
+ "Example configuration for performing a read using a SQL query: ::\n"
+ "\n"
+ " pipeline:\n"
+ " transforms:\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " query: 'SELECT * FROM table'\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " query: 'SELECT * FROM table'\n"
Polber marked this conversation as resolved.
Show resolved Hide resolved
+ "\n"
+ "It is also possible to read a table by specifying a table name and a list of columns. For "
+ "example, the following configuration will perform a read on an entire table: ::\n"
+ "\n"
+ " pipeline:\n"
+ " transforms:\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " table: 'my-table'\n"
+ " columns: ['col1', 'col2']\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " table: 'my-table'\n"
+ " columns: ['col1', 'col2']\n"
+ "\n"
+ "Additionally, to read using a <a href=\"https://cloud.google.com/spanner/docs/secondary-indexes\">"
+ "Secondary Index</a>, specify the index name: ::"
+ "\n"
+ " pipeline:\n"
+ " transforms:\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " table: 'my-table'\n"
+ " index: 'my-index'\n"
+ " columns: ['col1', 'col2']\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " table: 'my-table'\n"
+ " index: 'my-index'\n"
+ " columns: ['col1', 'col2']\n"
+ "\n"
+ "### Advanced Usage\n"
+ "#### Advanced Usage\n"
+ "\n"
+ "Reads by default use the <a href=\"https://cloud.google.com/spanner/docs/reads#read_data_in_parallel\">"
+ "PartitionQuery API</a> which enforces some limitations on the type of queries that can be used so that "
Expand All @@ -118,12 +112,10 @@ public String description() {
+ "\n"
+ "For example: ::"
+ "\n"
+ " pipeline:\n"
+ " transforms:\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " batching: false\n"
+ " ...\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " batching: false\n"
+ " ...\n"
+ "\n"
+ "Note: See <a href=\""
+ "https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.html\">"
Expand Down
14 changes: 6 additions & 8 deletions ...src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerWriteSchemaTransformProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,12 @@ public String description() {
+ "\n"
+ "Example configuration for performing a write to a single table: ::\n"
+ "\n"
+ " pipeline:\n"
+ " transforms:\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " project_id: 'my-project-id'\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " table: 'my-table'\n"
+ " - type: ReadFromSpanner\n"
+ " config:\n"
+ " project_id: 'my-project-id'\n"
+ " instance_id: 'my-instance-id'\n"
+ " database_id: 'my-database'\n"
+ " table: 'my-table'\n"
+ "\n"
+ "Note: See <a href=\""
+ "https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.html\">"
Expand Down
Loading
Loading