Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temp location to batch file loads #33115

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

claudevdm
Copy link
Contributor

BigQueryManagedIT.testBatchDynamicDestinations and BigQueryManagedIT.testBatchFileLoadsWriteRead failing because requires gcs temp location.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm
Copy link
Contributor Author

R: @ahmedabu98

@claudevdm
Copy link
Contributor Author

R: @damccorm FYI since you are running post commits for release cut.

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@ahmedabu98
Copy link
Contributor

Thanks for proactively fixing this @claudevdm

Can you run ./gradlew :sdks:java:io:google-cloud-platform:spotlessApply to fix spotless errors?

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmedabu98 ahmedabu98 marked this pull request as ready for review November 14, 2024 17:02
@ahmedabu98 ahmedabu98 merged commit 667269a into apache:master Nov 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants