-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add histogram to metrics container #33043
Add histogram to metrics container #33043
Conversation
7ba2869
to
44cf182
Compare
7db8de1
to
2f9125a
Compare
Run Java_IOs_Direct PreCommit |
Run Go PreCommit |
3518bf8
to
e0dcf4c
Compare
Run Java_Pulsar_IO_Direct PreCommit |
Run Java_PVR_Prism_Loopback PreCommit |
Run Java_IOs_Direct PreCommit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33043 +/- ##
============================================
- Coverage 59.03% 59.00% -0.03%
- Complexity 3186 3193 +7
============================================
Files 1146 1147 +1
Lines 176129 176150 +21
Branches 3366 3375 +9
============================================
- Hits 103975 103945 -30
- Misses 68800 68843 +43
- Partials 3354 3362 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e0dcf4c
to
377f753
Compare
Run Java PreCommit |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Run Prism_Python PreCommit 3.12 |
Run GoPrism PreCommit |
Run Java PreCommit |
69998f6
to
a206265
Compare
Run Java_Amazon-Web-Services2_IO_Direct PreCommit |
Run Java_IOs_Direct PreCommit |
a206265
to
1fd020c
Compare
Run Java_IOs_Direct PreCommit |
Run Java PreCommit |
Run Java_IOs_Direct PreCommit |
0007d72
to
3db7af0
Compare
Run Go PreCommit |
Run Java PreCommit |
Run Java_GCP_IO_Direct PreCommit |
3d67a2e
to
80482e6
Compare
Run Java PreCommit |
80482e6
to
5989886
Compare
5989886
to
26fbc4c
Compare
Run Prism_Python PreCommit 3.12 |
Run Java_Examples_Dataflow PreCommit |
Run Java PreCommit |
Run Java_GCP_IO_Direct PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me
We'll need to monitor ValidateRunner PostCommit test suites after merging this. In the past adding metrics type were seen to broke those tests
Add histogram to metrics container.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.