fix JDBC providers #32985
Merged
fix JDBC providers #32985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Signed-off-by: Jeffrey Kinard <[email protected]>
Polber
force-pushed
the
jkinard/fix-jdbc
branch
from
09a4079 to
b032393
Compare
Signed-off-by: Jeffrey Kinard <[email protected]>
Polber
force-pushed
the
jkinard/fix-jdbc
branch
from
b032393 to
314f881
Compare
Signed-off-by: Jeffrey Kinard <[email protected]>
damccorm
pushed a commit
that referenced
this pull request
Nov 13, 2024
* fix JDBC providers Signed-off-by: Jeffrey Kinard <[email protected]> * fix test failures Signed-off-by: Jeffrey Kinard <[email protected]> * fix typo Signed-off-by: Jeffrey Kinard <[email protected]> --------- Signed-off-by: Jeffrey Kinard <[email protected]>
damccorm
added a commit
that referenced
this pull request
Nov 13, 2024
* fix JDBC providers * fix test failures * fix typo --------- Signed-off-by: Jeffrey Kinard <[email protected]> Co-authored-by: Jeff Kinard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor standard_io.yaml to use snake_case for JDBC providers.
There was a change to the naming convention used by the cross-language service here: #31374
which also migrated most of the YAML provider definitions to use the new format. Unfortunately, JDBC providers that inherit the top-level JDBC Provider (MySQL, Postgres, Oracle and Sql Server) were missed. This causes YAML pipelines who use these transforms to fail when the
jdbc_type(formerlyjdbcType) config parameter is parsed during expansion.This PR refactors these transform config parameters to use the new snake_case naming convention.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.