Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#28187] Add a Java gradle task to run validates runner tests on Prism. #32919

Merged
merged 16 commits into from
Oct 24, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Oct 24, 2024

  • Add a Java gradle task to run validates runner tests on Prism.
  • Filtered to green tests. Added notes about what's broken with them, along with links to pertinent issues.
  • Broken tests that will terminate are in the sickbay list, to separate data, from configuration.
  • Add log_level filtering to prism. It was easier to have the Java PrismRunner wrapper re-launch the binary all the time. Set Java default to warning log. Can be overridden by a --prismLogLevel flag. Replaces the recently added --debug flag.
  • Add a Gradle Action to run as Precommit.

Part of #28187


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck lostluck marked this pull request as ready for review October 24, 2024 20:52
@github-actions github-actions bot added the build label Oct 24, 2024
@lostluck
Copy link
Contributor Author

R: @damondouglas

This should now be ready for review. The Github action was derived from the Flink PVR batch run, with a few unnecessary bits removed. It will be run once we merge this in.

I'll clean up the PreCommit, WsLint, and spotless once they come up.

@lostluck lostluck requested a review from damondouglas October 24, 2024 20:53
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment.

@lostluck lostluck merged commit 5a6b10a into apache:master Oct 24, 2024
18 of 19 checks passed
@lostluck
Copy link
Contributor Author

lostluck commented Oct 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants