-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining Python 3.8 Artifacts #32913
Conversation
The changes to the Python 3.9 post-commit are the most substantial, running at https://github.com/apache/beam/actions/runs/11485756985/job/31966569465 |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
PostCommit failures on the branch are due to #32936 |
// The default container uses Python 3.10. The goal here is to | ||
// duild Docker images for TensorRT tests during run time for python versions | ||
// other than 3.10 and add these tests in other python postcommit suites. | ||
dependsOn(":sdks:python:test-suites:dataflow:py310:inferencePostCommitIT") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this change broke the TensorRT tests - https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python.yml
The reason is that TensorRT depends on a docker image -
"sdk_container_image": "us.gcr.io/apache-beam-testing/python-postcommit-it/tensor_rt:latest", |
I think we need to use
beam/sdks/python/test-suites/containers/tensorrt_runinference/tensor_rt.dockerfile
Line 25 in 24a0447
COPY --from=apache/beam_python3.10_sdk:latest /opt/apache/beam /opt/apache/beam |
us.gcr.io/apache-beam-testing/python-postcommit-it/tensor_rt:latest
. @jrmccluskey would you mind following up and doing that? It looks like you already updated the dockerfile, so hopefully its smooth sailing
Removes remaining artifacts around Python 3.8 support, calls out support deprecation in CHANGES.md
Closes #31192
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.