Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining Python 3.8 Artifacts #32913

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Remove remaining Python 3.8 Artifacts #32913

merged 3 commits into from
Oct 29, 2024

Conversation

jrmccluskey
Copy link
Contributor

Removes remaining artifacts around Python 3.8 support, calls out support deprecation in CHANGES.md

Closes #31192


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey
Copy link
Contributor Author

The changes to the Python 3.9 post-commit are the most substantial, running at https://github.com/apache/beam/actions/runs/11485756985/job/31966569465

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added docker and removed docker labels Oct 24, 2024
@jrmccluskey
Copy link
Contributor Author

PostCommit failures on the branch are due to #32936

@liferoad liferoad mentioned this pull request Oct 28, 2024
3 tasks
@jrmccluskey jrmccluskey merged commit 6b772b2 into master Oct 29, 2024
94 of 100 checks passed
// The default container uses Python 3.10. The goal here is to
// duild Docker images for TensorRT tests during run time for python versions
// other than 3.10 and add these tests in other python postcommit suites.
dependsOn(":sdks:python:test-suites:dataflow:py310:inferencePostCommitIT")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change broke the TensorRT tests - https://github.com/apache/beam/actions/workflows/beam_PostCommit_Python.yml

The reason is that TensorRT depends on a docker image -

"sdk_container_image": "us.gcr.io/apache-beam-testing/python-postcommit-it/tensor_rt:latest",
- which is static, not built based on the test suite its in (this is actually what the comment in this file is saying).

I think we need to use

COPY --from=apache/beam_python3.10_sdk:latest /opt/apache/beam /opt/apache/beam
to build a new docker image for the tensorRT jobs and push it to us.gcr.io/apache-beam-testing/python-postcommit-it/tensor_rt:latest. @jrmccluskey would you mind following up and doing that? It looks like you already updated the dockerfile, so hopefully its smooth sailing

@damccorm damccorm deleted the 38cleanup branch October 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Sunset Python 3.8 support
3 participants