Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a vLLM notebook #32860

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Add a vLLM notebook #32860

merged 4 commits into from
Oct 24, 2024

Conversation

damccorm
Copy link
Contributor

Follow up now that #32528 is completed and released to create a notebook showing how to use vLLM


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

R: @jrmccluskey

I tagged you in https://colab.sandbox.google.com/drive/1rJNUArWBy_e3RZgVoqF3ayCDsQMwQy28 as well, which should maybe be easier to collaborate on if you have comments/suggestions

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod the nit that we might want to pin the vllm and openai versions

@damccorm damccorm merged commit 46c8cf4 into master Oct 24, 2024
3 checks passed
@damccorm damccorm deleted the users/damccorm/vllmNotebook branch October 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants