Using single temp maven local repository for release validation tasks #32841
Conversation
|
test run: https://github.com/apache/beam/actions/runs/11389484525/job/31688875732 EDIT: it stills fails one task at least it doesn't fail all tasks |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| return _execute(setPath + cmd) | ||
| """ | ||
| } | ||
| def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B" |
There was a problem hiding this comment.
Shall we also add "-U" in addition to this change ?
There was a problem hiding this comment.
Sorry later on I found my initial investigation in #32824 (comment) was wrong. In particular, the test workflow runs 8 tasks in parallel, each spin up an individual maven local repository, and delete after finish. So there isn't exist scenario that bad local repository cached can interfere the next run.
Using -U tag will cause the workflow making more requests to maven snapshot repository, which is known to be less stable in terms of availability, and I am afraid it would worsen rate limiting
|
Seems like this fix wasn't adequate or this resulted in a different regression. |
mitigate #32824 ; mitigate #32808
The task runs 8 individual tasks in parallel, each spins up a fresh local maven repository, likely get rate limited by maven repository server
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.