Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow numpy 2.1.x #32682

Merged
merged 2 commits into from
Oct 8, 2024
Merged

allow numpy 2.1.x #32682

merged 2 commits into from
Oct 8, 2024

Conversation

liferoad
Copy link
Contributor

@liferoad liferoad commented Oct 7, 2024

Fix #32681


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Oct 7, 2024
@liferoad liferoad marked this pull request as ready for review October 8, 2024 16:57
@liferoad liferoad requested a review from tvalentyn October 8, 2024 16:57
@liferoad liferoad changed the title [DO NOT MERGE] allow numpy 2.1.x allow numpy 2.1.x Oct 8, 2024
@liferoad
Copy link
Contributor Author

liferoad commented Oct 8, 2024

@tvalentyn looks like the tests are green.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn
Copy link
Contributor

tvalentyn commented Oct 8, 2024

Let's also update the numpy dependency in the base image requirement files to reflect this change in the container image.

looks like the tests are green.

note that we have not exercised the new version in postcommit tests, so we either merge as is and watch, or do a proactive round of testing like described in: https://cwiki.apache.org/confluence/display/BEAM/Dependency+management+guidelines+for+Beam+Python+SDK+maintainers#DependencymanagementguidelinesforBeamPythonSDKmaintainers-Howtoupdatedependencyversions?

@tvalentyn
Copy link
Contributor

Thanks a lot, @liferoad !

@liferoad
Copy link
Contributor Author

liferoad commented Oct 8, 2024

Let us merge this for now. If postcommits have issues, we can either revert or fix them. I will also do https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-HowtoupdatedependenciesthatareinstalledinPythoncontainerimages later.
cc @shunping FYI

@liferoad liferoad merged commit c5f7e16 into apache:master Oct 8, 2024
99 checks passed
@tvalentyn
Copy link
Contributor

ok, let's try to update deps this week as we try to do such updates early in release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Upgrade numpy to 2.x.
3 participants