Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force BQIO to output elements in the correct row #32584

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

damccorm
Copy link
Contributor

This fixes cases where the user is not in the global window


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm marked this pull request as ready for review September 27, 2024 21:28
@damccorm
Copy link
Contributor Author

R: @robertwb

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

sdks/python/apache_beam/io/gcp/bigquery.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/io/gcp/bigquery.py Show resolved Hide resolved
@damccorm damccorm merged commit e640b25 into master Sep 30, 2024
100 of 101 checks passed
@damccorm damccorm deleted the users/damccorm/bq_fix branch September 30, 2024 16:43
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
* Fix bqio

* import fix

* syntax

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants