Fix backlog reported by periodicsequence in python and go sdks to not include future outputs #32513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scwhittle
force-pushed
the
periodic_sequence_python
branch
5 times, most recently
from
58705cd to
c8670ae
Compare
…de future outputs
scwhittle
force-pushed
the
periodic_sequence_python
branch
from
c8670ae to
77c969b
Compare
|
Fixes #32506 |
scwhittle
changed the title
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
tvalentyn
approved these changes
Sep 23, 2024
|
|
||
| # On drain, immediately stop emitting new elements | ||
| def truncate(self, unused_element, unused_restriction): | ||
| return None | ||
|
|
||
|
|
||
| def sequence_backlog_bytes(element, now, offset_range): |
There was a problem hiding this comment.
Would this be an appropriate docstring?
"Calculates size of the output that the sequence should have emitted up to now"
|
would you mind adding to PR descritption why we want this change? thanks! |
scwhittle
force-pushed
the
periodic_sequence_python
branch
from
4525f14 to
723190a
Compare
|
updated PR comment as well |
tvalentyn
approved these changes
Sep 24, 2024
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
… include future outputs (apache#32513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects monitoring and autoscaling decisons made by runners.
In particular the Dataflow runner utilizes this backlog bytes for autoscaling and unbounded periodic sequences previously reported a large backlog causing pipelines to upscale and not downscale.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.