Add keyrings.google-artifactregistry-auth #32404
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
baeminbo
force-pushed
the
baeminbo-python-keyrings
branch
from
b30b0b1 to
bac22c3
Compare
| # Authentication for Google Artifact Registry when using --extra-index-url or --index-url in requirements.txt in | ||
| # Dataflow, which allows installing python packages from private Python repositories in GAR. | ||
| keyrings.google-artifactregistry-auth |
There was a problem hiding this comment.
I'm good with the change, just note another choice will be add this dependency to [gcp] extension in setup.py. Is there a preference here?
There was a problem hiding this comment.
+1 - I think adding it to the gcp extension (here) is probably a slightly better option.
There was a problem hiding this comment.
Thanks! I moved it to [gcp] extension in setup.py.
| # Authentication for Google Artifact Registry when using --extra-index-url or --index-url in requirements.txt in | ||
| # Dataflow, which allows installing python packages from private Python repositories in GAR. | ||
| keyrings.google-artifactregistry-auth |
There was a problem hiding this comment.
+1 - I think adding it to the gcp extension (here) is probably a slightly better option.
|
Thanks for doing this! |
baeminbo
force-pushed
the
baeminbo-python-keyrings
branch
from
e269e47 to
bab40ff
Compare
|
yaml xlang direct precommit failed twice, seen this test flaky in general, merging for now |
* Add keyrings.google-artifactregistry-auth * Update base image requirements. * Move keyrings.google-artifactregistry-auth to [gcp] extension in setup.py
Fix #32123.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.