Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google-ads API to v17 #32244

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Bump google-ads API to v17 #32244

merged 1 commit into from
Aug 20, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 19, 2024

Fix #32241

however, the way GoogleAdsIO bookkeeping Google-ads API version requires recurring breaking change, including this PR, which should be revisited later

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Aug 19, 2024

R: @bcoryat

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Aug 20, 2024

R: @sjvanrossum

@sjvanrossum
Copy link
Contributor

LGTM, thank you for picking this up!
As a follow up, we could refactor the concrete versioned transforms into a heavily parametrized package-private abstract base class and subclass that for the provided versions of the Google Ads API at the current artifact version.

It's still a chore since the SDK supplies no common super types or interfaces that can be used for type bounds, so the best we can do in more than a few places is something like ? extends Message, but it makes it a bit easier to add multiple versions and gradually deprecate older releases throughout the year.

@Abacn Abacn merged commit ff64566 into apache:master Aug 20, 2024
28 checks passed
@Abacn Abacn deleted the googleadsv17 branch August 21, 2024 15:39
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Google Ads Connector broken, needs to be updated to latest version of the Google Ads API
2 participants