Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard delete function to multi_process_shared #32238

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Aug 19, 2024

Adds an unsafe delete option to be used for garbage collection of multi_process_shared objects. This allows cleanup of multiprocess objects even if some references have been entirely lost (e.g. due to running in a subprocess mode) or if its unclear when they'll be invoked again (because Beam may not schedule work to that DoFn for a bit).

This is intentionally unsafe and should only be used when other synchronization mechanisms are in place to prevent usage of the already deleted object. For example, this will be used as part of our runinference timeout feature - for more details see https://docs.google.com/document/d/19ves6iv-m_6DFmePJZqYpLm-bCooPu6wQ-Ti6kAl2Jo/edit#heading=h.cfdh3ijyabi3

Part of #32137


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit aa13a69 into master Aug 19, 2024
89 checks passed
@damccorm damccorm deleted the users/damccorm/mp_hard_delete branch August 19, 2024 14:41
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
* Add hard delete function to multi_process_shared

* better testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants