Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Use non-deprecated docker types in environment. #32092

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 6, 2024

Attempt 2 in updating the docker configuration types to their non-deprecated versions.

This is to unblock updating to v27 of the docker libraries which removes the deprecated aliases.

Deps updates also require moving to go 1.21, so that change is happening here as well.

See #32059.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.67%. Comparing base (fb49e96) to head (cc31455).
Report is 7 commits behind head on master.

Files Patch % Lines
...go/pkg/beam/runners/prism/internal/environments.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             master   #32092    +/-   ##
==========================================
  Coverage     58.67%   58.67%            
  Complexity     3025     3025            
==========================================
  Files          1121     1121            
  Lines        172734   172850   +116     
  Branches       3275     3275            
==========================================
+ Hits         101350   101421    +71     
- Misses        68083    68123    +40     
- Partials       3301     3306     +5     
Flag Coverage Δ
go 34.62% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit 0a42afa into apache:master Aug 6, 2024
8 checks passed
@lostluck lostluck deleted the dockerFix branch August 6, 2024 23:10
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
* [prism] Use non-deprecated docker types in environment.

* Include Go mod changes.

* Update testcontainers-go

* revert toolchain change

* go mod tidy requirement, update minimum Go version.

* Note Minimum Go version update.

---------

Co-authored-by: lostluck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants