Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#31605][Go SDK] Disable SoftDeletePolicy when creating a default bucket #31748

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

mls3odp
Copy link
Contributor

@mls3odp mls3odp commented Jul 2, 2024

This PR addresses #31605.

@github-actions github-actions bot added the go label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the contribution!

@lostluck lostluck merged commit 366db73 into apache:master Jul 2, 2024
7 checks passed
@lostluck lostluck changed the title Disable SoftDeletePolicy when creating a default bucket [#31605] Disable SoftDeletePolicy when creating a default bucket Jul 2, 2024
@lostluck lostluck changed the title [#31605] Disable SoftDeletePolicy when creating a default bucket [#31605][Go SDK] Disable SoftDeletePolicy when creating a default bucket Jul 2, 2024
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants