Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#28187][Prism] Relax or fix issues in Prism to allow Python pipelines to execute. #31694

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

lostluck
Copy link
Contributor

Small grab bag of Prism fixes to make progress with #31583 and #28187. This follows up from #31644 which was about unblocking WordCount.

  • Add a debug coder print function to better see structure of coders, for debugging prism coder issues. Intended for targetted usage and may not be a permanent fixture.
  • Re-write PCollections that are used as Flatten inputs to use the Flatten's output coder as their coder. Python has a habit of re-deriving coders, so we need to ensure that encoded bytes can be decoded on the other side. Prism doesn't unzip/sink flattens yet, which may make this unnecessary in the future.
  • Remove a noisy log about composite URNs. It is no longer useful, especially with Python at this stage.
  • recover from panics when building stages and their descriptors, so a prism instance doesn't crash during execution of a sequence of tests. This produces more meaningful test output to users as well, though most failures at this stage represent prism bugs.
  • Relaxing OutputTime and Always Trigger in the pre-filter allows more tests to run. Some are failing due to these features not being correctly implemented at this stage, so this is acceptable for now to allow Python usage to advance.
  • The Python SDK was very noisy when the GRPC server was hard stopped, vs Gracefully stopped. This removes the noise, but keeps the hard stop after 5 seconds just in case an SDK is taking too long to shut down after the control RPC is closed.

These are tested via the Python SDK validates runner tests at the present time.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck
Copy link
Contributor Author

lostluck commented Jun 27, 2024

cc: @damondouglas As an FYI This will probably shift a few of the Java tests as well. I'll be doing an audit of prism issues/PRs and get a targetted list of features to implement (and bugs to fix) for us to burn down the next few months.

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit ba04213 into apache:master Jun 27, 2024
7 checks passed
@lostluck lostluck deleted the pleasingPythonPrism branch June 27, 2024 20:24
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants