Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't specify an unnecessary config given that tox task and gradle config already defines the Python version." #31283

Merged
merged 2 commits into from
May 14, 2024
Merged

Revert "Don't specify an unnecessary config given that tox task and gradle config already defines the Python version." #31283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bff73de
Revert "Don't specify an unnecessary config given that tox task and g…
tvalentyn May 13, 2024
1917930
Trigger tests
tvalentyn May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs="--ignore=apache_beam/dataframe/ --ignore=apache_beam/ml/ --ignore=apache_beam/examples/ --ignore=apache_beam/runners/ --ignore=apache_beam/transforms/"
-Pposargs="--ignore=apache_beam/dataframe/ --ignore=apache_beam/ml/ --ignore=apache_beam/examples/ --ignore=apache_beam/runners/ --ignore=apache_beam/transforms/" \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Dataframes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/dataframe/
-Pposargs=apache_beam/dataframe/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/examples/
-Pposargs=apache_beam/examples/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_ML.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:testPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}ML
arguments: |
-Pposargs=apache_beam/ml/
-Pposargs=apache_beam/ml/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Runners.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/runners/
-Pposargs=apache_beam/runners/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_Python_Transforms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
with:
gradle-command: :sdks:python:test-suites:tox:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:preCommitPy${{steps.set_py_ver_clean.outputs.py_ver_clean}}
arguments: |
-Pposargs=apache_beam/transforms/
-Pposargs=apache_beam/transforms/ \
-PpythonVersion=${{ matrix.python_version }}
- name: Archive Python Test Results
uses: actions/upload-artifact@v4
if: failure()
Expand Down
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/transforms/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class SqlTransform(ExternalTransform):
`apache_beam.examples.wordcount_xlang_sql`, `apache_beam.examples.sql_taxi`,
and `apache_beam.transforms.sql_test`.

For more details about Beam SQL in general see the `Java transform
For more details about Beam SQL in general, see the `Java transform
<https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/extensions/sql/SqlTransform.html>`_,
and the `documentation
<https://beam.apache.org/documentation/dsls/sql/overview/>`_.
Expand Down
Loading